ci: add fmt and clippy to ci workflow #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eightfilms
changed the title
pinhaocypher
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the above in separate jobs as well as changed the test step a bit.
For tests, we separate compilation step with test step: see this post for justification.
Add very basic fmt and clippy checks,
as well as taplo-fmt which checks the formatting of toml files.taplo is acting weird so i'm excluding it for now, rustfmt and clippy should be enough for now anyway.ps: I also made the switch to dtolnay's ci action for cleaner syntax + actions/rs isn't really maintained anymore